Deploying windmill with    Cloudflare Pages

View logs

Claude finished @rubenfiszel's task in 1m 20s —— View job

Review of PR #7945 — chore(main): release 2.0.0

• Gather context and read changed files
• Review changes
• Post review feedback

Summary

This is an automated Release Please PR that bumps the version from 1.634.6 to 2.0.0. It touches only two files: CHANGELOG.md (new changelog entry) and version.txt (version bump).

Observations

1. Intentionality of the 2.0.0 major bump

The version jump from 1.634.6 → 2.0.0 is driven by the BREAKING CHANGE footer in commit 37d1277 (PR #7917 — feat(cli): add lint command), which replaced FlowValidator/validateFlow() with WindmillYamlValidator.validate(doc, target).

Notably, there was a previous attempt to prevent this bump:

• Commit 9e7b178 added a release-as: 1.635.0 override to .github/workflows/release-please.yml with the message "override release-please to 1.635.0 to prevent unintended 2.0 bump"
• Commit 4fe9314 then removed that override ("remove temporary release-as override")

This means the 2.0 bump was initially considered unintended, but the override was later deliberately removed, allowing this PR to be created. Please confirm this is the intended outcome. A major version bump has significant implications for users — it signals breaking changes and may affect downstream tooling, Docker image tags, and deployment pipelines.

2. Changelog entry includes self-contradictory bug fix

The changelog lists this bug fix under 2.0.0:

• override release-please to 1.635.0 to prevent unintended 2.0 bump (9e7b178)

This is somewhat contradictory — the fix to prevent the 2.0 bump is listed as part of the 2.0 release itself. This was picked up automatically by Release Please from the commit history and is harmless, but it reads oddly. Consider whether this entry should be manually cleaned up before merging.

3. Breaking change scope is CLI-only

The breaking change (FlowValidator → WindmillYamlValidator) is scoped to cli: and affects the windmill-yaml-validator npm package. The core Windmill platform (backend/frontend) is not affected. If this is the only breaking change, it may be worth noting in release communications that the 2.0.0 bump is driven by a CLI tooling change, not a platform-level breaking change, to avoid alarming self-hosted users.

Code Quality

The changes themselves are mechanically correct:

• CHANGELOG.md follows the standard Release Please format with proper commit links
• version.txt correctly reflects the new version

No bugs, security issues, or performance concerns — this is purely a version metadata update.

Verdict

The PR is technically correct. The main question is whether the 2.0.0 major version bump is intentional given the history of trying to prevent it. If it is intentional, this PR is ready to merge as-is (with an optional cleanup of the self-contradictory changelog entry).

Testing instructions

This is a release metadata PR — there are no functional changes to verify in the app interface. To validate, confirm that after merge the published release on GitHub shows version 2.0.0 with the correct changelog, and that Docker images / CLI packages are tagged accordingly.